Goals

• Investigate and fix the bug introduced in Week 7 regarding diff files staying in loading mode forever.
• Create a toggle effect on the button in the floating banner that expands / collapses the diffFileIndexView in the floating banner.
• Look into Jasmine Tests for the floating banner.

Outcome

Link to a short GIF of the current state of the project:

Week 8: Mar 19th

• Posted a review on Simon Zhang's review request.
• Fixed the bug introduced in week 7 regarding diff files staying in loading mode forever.
• Created a toggle effect on the dropdown button that expands / collapses the diffFileIndexView inside the floating banner.
• Received a code review from Barret, and responded accordingly by updating my code and discussing the solution to the window intersection problem.
• Found two bugs with the toggle button:
  • 1. After expanding the list and navigating to a diff file, the toggle button still stays in "expand" mode although the list has collapsed. The user currently has to click twice on the button to expand the list after said scenario.
  • 2. Scrolling in the diff view when the list is expanded will automatically collapse the list. However, the toggle button still stays in "expand" mode. The user currently has to click twice on the button to expand the list after said scenario.
• I did not look into Jasmine tests this week, as I ran out of time solving the first two tasks.