Link to screenshots page:

Week 4: Feb 15th

Did more research on jQuery and CSS styling.

Finished task 1 (move dropdown button to the right) by adding overflow: hidden and float: right styling to the divs.

Here is a list of the rest that I got done this week:

• Improved the styling on the floating banner:
  • Fixed a width issue allowing the banner to reach all the way to the right of the screen.
  • Fixed a bug where the banner was visible at the top of the page for users with bigger screen sizes. It is now hidden until the user scrolls below the title of the first diff file.
  • Fixed a bug where the entire "diffs" section jumped down 68 pixels every time the banner appeared. I solved this by adding "display: none" to the banner div.
• Added a ReviewableDiffCollection file which is a collection of DiffReviewable models.
• Further developed the new DiffFileIndexModel file:
  • Added an attribute for reviewableDiffs storing a collection of reviewableDiffViews.
  • Added a set function that overrides the backbone model's standard set function. We have to override this function when the model's attributes are collections.
  • Added an addDiff function that adds the passed in reviewableDiffView to the collection stored in this model.
  • Added a signal that emits every time the model is changed. This signal is set off in the set and addDiff functions by the .trigger('update') call.
• The addDiff() function in the diffFileIndexView.js file is still a work in progress. I am currently only adding to the model. It needs to listen to the changes on the model and update the views accordingly. This function will be changed to a handler function for the model.