Goals

• Respond to Anni Cao's review on my patch
• Improve styling on the toggle button and the banner
• Further develop Jasmine tests

Outcome

• Updated my code as requested by Anni. Instead of defining each border type, I now use the shorthand version border: 0 @color;
• I realized I had hard-coded the banner's colors in the banner's styling. Instead of using hard-coded color values, I am now using @review-request-border-color and @review-request-bg
• I added custom styling to the toggle button to make it look more like the mockup's toggle button.
• I added a border-bottom to the banner to differentiate the banner from the diff view itself. I am currently using border-bottom: 1px solid @review-request-border-color;
• I realized I wasn't navigating the same way the existing anchors were navigating (appending the diff file ID to the URL, calculating the offset, etc). I removed the existing navigation functionality and hooked it up to the diffViewerPageView. The banner now uses the same functions as the original anchors, and hence they are now acting similarly.
• I polished the precise area the anchors navigate to by taking into account the height of the banner and the margin-bottom of the diff-container .

Screenshots and Demo Video

Week 11: Apr 6th (Demo Day 3)